Conversation
|
Hey @jgabry, I think most looks good. Only in |
VeenDuco
left a comment
VeenDuco
left a comment
There was a problem hiding this comment.
Hey @jgabry, I think most looks good. Only in R/mcmc-diagnostics.R there are still some occurrences of labels = c("low", "ok", "high") instead of labels = c("low", "mid", "high"). I think everywhere else ok was replaced with mid. Everything else is a quite straightforward adaptation of the other functions and looks good.
Also in man/MCMC-diagnostics.Rd some occurances of ok description, but I think those are fine to keep.
|
Thanks @VeenDuco.
Can you point me to where you still see |
2 participants
This PR is not new, just a reworked version of PR #210 from @VeenDuco. For some reason that PR got messed up and it lists 223 files changed when there should only be a few. This separate PR includes what I think were the intended changes from @VeenDuco, which I had already looked at and approved (so I think this is ready to go). I also added a few tests.
@VeenDuco would you mind taking a quick look at this before I merge it?